Skip to content

ui: Fix the "Next chapter" link position #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ui: Fix the "Next chapter" link position #993

wants to merge 1 commit into from

Conversation

WofWca
Copy link
Contributor

@WofWca WofWca commented Aug 3, 2019 •
edited
Loading

Remove the gap between it and the right edge of the page.

Demo: https://wofwca.github.io/mdBook/format/config.html

This reverts f1cd9f5 (That fixed /rust-lang/book/issues/29)
The page layout has been restructured and this workaround is no
longer required

@WofWca
ui: Fix the "Next chapter" link position
f5a4dc9 
Remove the gap between it and the right edge of the page
This reverts f1cd9f5
The page layout has been restructured and this workaround is no
longer required
@WofWca
Copy link
Contributor Author

WofWca commented Aug 3, 2019

I don't think that my changes are the cause of the build failure.

@ehuss
Copy link
Contributor

ehuss commented Aug 3, 2019

I don't think that my changes are the cause of the build failure.

Looks like an issue due to mozilla/sccache#488. cc @lzutao

@WofWca WofWca mentioned this pull request Aug 3, 2019
Merged
@ehuss
Copy link
Contributor

ehuss commented Aug 7, 2019

Hm, so in testing this out this seems to cause some issues on firefox and chrome. If the scroll bar is not displayed, this prevents the scroll bar from appearing when the cursor is positioned over it. You have to scroll a little bit to get it to appear, and then you can interact with it. It seems a little awkward. Is there something in particular this is trying to improve or fix?

@WofWca
Copy link
Contributor Author

WofWca commented Aug 8, 2019 •
edited
Loading

Could you please provide more details on how to reproduce this? I've played around a bit and couldn't seem to experience this.

Is there something in particular this is trying to improve or fix?

Yes.
Sometimes you miss the button by clicking right on this gap, especially when there's no scrollbar and you just move the cursor right to the edge of the screen.
Also with the #994 change, this should make it look better (remove the gap).

@ehuss
Copy link
Contributor

ehuss commented Aug 8, 2019

Hm, maybe it is unique to Firefox on macos. Firefox auto-hides the scroll bar, and you end up with this situation:

next_firefox_macos

Clicking in this region goes to the next page instead of scrolling.

What's weird is that on safari and chrome, the scroll bar never auto-hides. That's not normal, so I guess it is related to some of the scrollbar css settings?

@ehuss ehuss added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Dec 20, 2021
@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2025

☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WofWca @ehuss @rustbot